Conversation
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic to be a potential reviewer. |
MorrisJobke
approved these changes
Jan 19, 2017
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Tested together with #3157
Member
|
@schiessle @nickvergessen @blizzz @rullzer Mind to review this one here? |
3373ecb to
3bbe869
Compare
Member
|
I updated the 3rdparty module to reflect the rebase there. |
Signed-off-by: Robin Appelman <robin@icewind.nl>
3bbe869 to
c9ecd64
Compare
Member
Author
|
Rebased since 3rdparty is merged |
Member
|
@karlitschek Backport for #1166? |
Member
|
please backport |
Member
|
@icewind1991 Could you create the backport PRs, thanks :) |
Member
|
Ping @icewind1991 |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1166